Configurable update player attribute on held item change#11589
Closed
LoliColleen wants to merge 1 commit into
Closed
Configurable update player attribute on held item change#11589LoliColleen wants to merge 1 commit into
LoliColleen wants to merge 1 commit into
Conversation
lynxplay
requested changes
Nov 23, 2024
Contributor
lynxplay
left a comment
lynxplay
left a comment
There was a problem hiding this comment.
The actual diff should probably be moved into the vanilla bug fix patch we have. Fix a bunch of vanilla bugs
(Also welcome to paper, thank you for your first PR!! Glad to see it isn't in the damage calculation logic 😉 )
| public boolean disableUnloadedChunkEnderpearlExploit = false; | ||
| public boolean preventTntFromMovingInWater = false; | ||
| public boolean splitOverstackedLoot = true; | ||
| + public boolean updatePlayerAttributeOnHeldItemChange = false; |
Contributor
There was a problem hiding this comment.
This diff goes to the paper config patch.
| this.player.getInventory().selected = packet.getSlot(); | ||
| this.player.resetLastActionTime(); | ||
| + | ||
| + if (this.player.level().paperConfig().fixes.updatePlayerAttributeOnHeldItemChange) { |
Contributor
There was a problem hiding this comment.
This diff needs paper comments.
kennytv
added
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://bugs.mojang.com/browse/MC-28289
With the option on, player's attributes can be updated when they change their held item slot.
This option is set to false in default because the bug is a vanilla bug.