Skip to content

Save players before disabling plugins#11786

Closed
DerEchtePilz wants to merge 1 commit into
PaperMC:mainfrom
DerEchtePilz:dev/server-shutdown-operation-order
Closed

Save players before disabling plugins#11786
DerEchtePilz wants to merge 1 commit into
PaperMC:mainfrom
DerEchtePilz:dev/server-shutdown-operation-order

Conversation

@DerEchtePilz
Copy link
Copy Markdown
Contributor

Original: #9679

While I still think that this PR is valid, I also thought about maybe changing the way it currently is in the /restart command since the goal is to sync the behaviour of shutting down the server and restarting the server when it comes to saving players/disabling plugins. I am open for input here.

@DerEchtePilz DerEchtePilz requested a review from a team as a code owner December 23, 2024 15:36
@DerEchtePilz DerEchtePilz force-pushed the dev/server-shutdown-operation-order branch from 33041cc to 302ea39 Compare December 23, 2024 15:40
@lynxplay
Copy link
Copy Markdown
Contributor

To note that the same restrictions apply as before, even now that we are hardforked.
Will need to wait for the next release at the earliest.

@lynxplay
Copy link
Copy Markdown
Contributor

lynxplay commented Dec 23, 2024

After some more thinking on this, I'll close this.
Generally post hardfork we'll try to use the fact that the PR queue was soft reset to keep it as low as possible.
This change (while I agree that it would be a nice thing somewhere down the line) is so unlikely to happen and if the team ever decides on actually implementing this would require a lot of community communication / announcements / planning etc to make sure plugin developers have time to actually adapt to this as we cannot slowly phase this behaviour out.

It would be a hard break in a single version.

As such, I'll close this PR with the idea of "if we ever feel like it is the right time for this to happen, we'll go look for this PR / implement it ourselfs and smack you in as a co-author, but for now, this PR adds no value to the PR queue as no one can merge it / review to make it mergable".

Hope that makes sense for you, thank you anyway for the PR, if we ever manage to have the communications in place to pull such a large breaking change, I'll make sure you are properly credited for your work here 👍

// edit: If you wanna explore reload mechanics around this, go for it I guess, we can evaluate such a change on a separate PR.

@lynxplay lynxplay closed this Dec 23, 2024
@lynxplay lynxplay added for: future Issue scheduled for resolution at some point in the future. and removed for: future Issue scheduled for resolution at some point in the future. labels Dec 23, 2024
@DerEchtePilz
Copy link
Copy Markdown
Contributor Author

Yeah, I understand. I honestly didn't even expect it to be merged even remotely soon despite hardfork being real now because of the nature of this PR.

@DerEchtePilz DerEchtePilz deleted the dev/server-shutdown-operation-order branch December 23, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants