Save players before disabling plugins#11786
Conversation
33041cc to
302ea39
Compare
|
To note that the same restrictions apply as before, even now that we are hardforked. |
|
After some more thinking on this, I'll close this. It would be a hard break in a single version. As such, I'll close this PR with the idea of "if we ever feel like it is the right time for this to happen, we'll go look for this PR / implement it ourselfs and smack you in as a co-author, but for now, this PR adds no value to the PR queue as no one can merge it / review to make it mergable". Hope that makes sense for you, thank you anyway for the PR, if we ever manage to have the communications in place to pull such a large breaking change, I'll make sure you are properly credited for your work here 👍 // edit: If you wanna explore reload mechanics around this, go for it I guess, we can evaluate such a change on a separate PR. |
|
Yeah, I understand. I honestly didn't even expect it to be merged even remotely soon despite hardfork being real now because of the nature of this PR. |
Original: #9679
While I still think that this PR is valid, I also thought about maybe changing the way it currently is in the
/restartcommand since the goal is to sync the behaviour of shutting down the server and restarting the server when it comes to saving players/disabling plugins. I am open for input here.