You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There's no universal way to check if mob can fly and the only shared logic between flying mobs in NMS is FlyingPathNavigation.
Not sure about the method name, but should be ok
ok, so I just found out that there is also FlyingMoveControl.
is the current implementation ok, or should I add Mob#canFly and check for FlyingMoveControl?
edit: also, it seems that EnderDragon doesn't use FlyingPathNavigation nor FlyingMoveControl, any thoughts?
Yea, Phantoms and Ghasts don't use it either.
This seems like a bit of an impossible task to properly do.
This is at best gonna be an EntityTag once we have the ability to properly define custom paper tags, but for now I don't think a new API method like this makes sense given the server has many definitions for flying entities (e.g. FlyingMob vs FlyingPathNavigation vs whatever they may come up next).
Thank you anyway for the PR, does highlight that we should work towards custom tags maybe somewhat soon :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no universal way to check if mob can fly and the only shared logic between flying mobs in NMS is
FlyingPathNavigation.Not sure about the method name, but should be ok