Add PlayerMoveVehicleEvent#11835
Conversation
|
This Potentially resolves #11633 |
|
I would suggest improving the vehicle move event and/or adding a "mount steer event" and completely stop calling the player move event for passengers |
|
A |
|
I think a One case I didn't think about in advance that came to mind while writing this are pigs and striders |
|
The problem with vehicle movement is that there are a lot of overarching concepts which look similar but are entirely different, there were discussions over input events in the past, and there was no viable workable solution that I could see for providing events which are actually useful to devs within the context of the discussions they had (i.e. overriding the entities move controller) |
741bb6d to
7f778ba
Compare
|
I have no interest in upkeeping this. In the end, we upkeep a breaking change for an "exploit" that is most likely not relevant nowadays. So until that is removed, riding statistics will not work. |
Reworked Vehicle PlayerMoveEvent Handling
The
PlayerMoveEventis triggered whenever a player controls a vehicle.This event is generally broken, and does not represent what is actually happen. For example, the event used the player's location as the "from" position and the vehicle's location as the "to" position. This caused significant issues and confusion:
setTocalls effectively useless.Fixes:
#8214
#7021
In order to best clean up the event logic, the solution is to center the event around the vehicle rather than the player.
8mb.video-Ear-qyB5Bf5T.mp4