Skip to content

Default to not creating snapshots in BlockState getters #11913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
me4502 wants to merge 2 commits into from
Closed

Default to not creating snapshots in BlockState getters #11913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
023a821
Don't use snapshots by default when creating block entity representat…
me4502 Jan 5, 2025
f886030
Fixed missed source patch
me4502 Jan 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion paper-api/src/main/java/org/bukkit/Chunk.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ static long getChunkKey(int x, int z) {
@NotNull
// Paper start
default BlockState @NotNull [] getTileEntities() {
return getTileEntities(true);
return getTileEntities(false);
}

/**
Expand Down
2 changes: 1 addition & 1 deletion paper-server/patches/sources/net/minecraft/world/level/block/entity/BlockEntity.java.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@
+ // CraftBukkit start - add method
+ public org.bukkit.inventory.InventoryHolder getOwner() {
+ // Paper start
+ return getOwner(true);
+ return getOwner(false);
+ }
+ public org.bukkit.inventory.InventoryHolder getOwner(boolean useSnapshot) {
+ // Paper end
Expand Down
2 changes: 1 addition & 1 deletion paper-server/src/main/java/org/bukkit/craftbukkit/CraftChunk.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ public Entity[] getEntities() {
@Override
public BlockState[] getTileEntities() {
// Paper start
return getTileEntities(true);
return getTileEntities(false);
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion paper-server/src/main/java/org/bukkit/craftbukkit/block/CraftBlockStates.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ public static Class<? extends CraftBlockState> getBlockStateType(BlockEntityType

public static BlockState getBlockState(Block block) {
// Paper start
return CraftBlockStates.getBlockState(block, true);
return CraftBlockStates.getBlockState(block, false);
}
public static BlockState getBlockState(Block block, boolean useSnapshot) {
// Paper end
Expand Down