Update CustomTimingsHandler Nag Message#11923
Merged
Conversation
ghost
self-requested a review
as a 
ghost
changed the title
Member
|
Maybe can be good mention spark here and maybe an alternative for what this class is used (? |
lynxplay
previously approved these changes
Jan 6, 2025
lynxplay
requested changes
Jan 7, 2025
Contributor
lynxplay
left a comment
lynxplay
left a comment
There was a problem hiding this comment.
Timings is already removed, only the API types are left as NO-OP.
Probably good to mention that in this message.
Regarding spark, I am not aware of anything similar spark offers, not that there is much of a point.
lynxplay
approved these changes
Jan 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No point telling them to switch to timings.of since timings will be removed soon