Skip to content

Fix wrong nullability #11949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lynxplay merged 2 commits into from
Jan 11, 2025
Merged

Fix wrong nullability #11949

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28fe5ce
Fix wrong nullability
Jan 11, 2025
d4fd172
remove annotation completely
Jan 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions paper-server/patches/sources/net/minecraft/network/syncher/SynchedEntityData.java.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,16 @@
public boolean isDirty() {
return this.isDirty;
}
@@ -169,6 +_,20 @@
@@ -169,6 +_,19 @@
return new SynchedEntityData(this.entity, this.itemsById);
}
}
+
+ // Paper start
+ // We need to pack all as we cannot rely on "non default values" or "dirty" ones.
+ // Because these values can possibly be desynced on the client.
+ @Nullable
+ public List<SynchedEntityData.DataValue<?>> packAll() {
+ final List<SynchedEntityData.DataValue<?>> list = new ArrayList<>();
+ final List<SynchedEntityData.DataValue<?>> list = new ArrayList<>(this.itemsById.length);
+ for (final DataItem<?> dataItem : this.itemsById) {
+ list.add(dataItem.value());
+ }
Expand Down