Add EntityHarvestBlockEvent#11951
Conversation
Warriorrrr
left a comment
Warriorrrr
left a comment
There was a problem hiding this comment.
The case of foxes harvesting a sweet berry bush is currently missing, can be added in the FoxEatBerriesGoal#pickSweetBerries method
ready i try to handle the whole logic where the "first" (with first i mean the first of the stack) item its used for the "hand" of the fox and the rest for drop/pop. |
|
I'm a little torn, because of the fact that we arent sharing any inheritance I really think we should make the EntityHarvestBlockEvent "more proper".
Issue is then people wanting to use the other event may get a bit confused. |
yeah i prefer keep the two events like the same.. if not then modify the two with this new "behaviours" but set itemstack? i mean all are in the list or i bad read something? |
Warriorrrr
left a comment
Warriorrrr
left a comment
There was a problem hiding this comment.
Looking back at this now it would indeed seem better to make the new event more proper with defensive copying for the list and items and adding setters.
github-project-automation
Bot
moved this from Awaiting final testing
to Changes required
in Paper PR Queue
like Owen mention not? PS: Another PR in the conflict list :( |
Co-authored-by: Warrior <50800980+Warriorrrr@users.noreply.github.com>
# Conflicts: # paper-server/patches/sources/net/minecraft/world/level/block/CaveVines.java.patch # paper-server/patches/sources/net/minecraft/world/level/block/ComposterBlock.java.patch # paper-server/src/main/java/org/bukkit/craftbukkit/event/CraftEventFactory.java
Doc94
force-pushed
the
feature/entity-harvest-event
branch
from
c4774c2 to
058ff8f
Compare
|
Ok now the entity event handle clone of items an the immutable list.... not sure if need make this to the player event too (what is a breaking change) or this is ready.... |
4 participants
This starts in discord where the Composter when drop a bone meal not has any event... the first thing was use the Drop or Dispenser event but that not handle correctly in this behaviour... then Machine Maker suggest a new event.
Then this PR add a new event for the case when a Entity harvest a block currently for Vines and Composter. this new event cannot be a base of the player side by the original design... then add in the docs the mention for this cases...