Skip to content

Hide unnecessary decorated pot data #11957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kennytv merged 1 commit into from
Jan 12, 2025
Merged

Hide unnecessary decorated pot data #11957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions ...patches/sources/net/minecraft/world/level/block/entity/DecoratedPotBlockEntity.java.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,28 @@
public static final String TAG_SHERDS = "sherds";
public static final String TAG_ITEM = "item";
public static final int EVENT_POT_WOBBLES = 1;
@@ -41,8 +_,8 @@
protected void saveAdditional(CompoundTag tag, HolderLookup.Provider registries) {
super.saveAdditional(tag, registries);
this.decorations.save(tag);
- if (!this.trySaveLootTable(tag) && !this.item.isEmpty()) {
- tag.put("item", this.item.save(registries));
+ if (!this.trySaveLootTable(tag) && !this.item.isEmpty()) { // Paper - diff on change - hide unnecessary update data
+ tag.put("item", this.item.save(registries)); // Paper - diff on change - hide unnecessary update data
}
}

@@ -66,7 +_,12 @@

@Override
public CompoundTag getUpdateTag(HolderLookup.Provider registries) {
- return this.saveCustomOnly(registries);
+ // Paper start - hide unnecessary update data
+ // Like chests, decorated pots should not allow clients to inspect their contents without breaking them.
+ final CompoundTag compoundTag = new CompoundTag();
+ this.decorations.save(compoundTag);
+ return compoundTag;
+ // Paper end - hide unnecessary update data
}

public Direction getDirection() {