Disable the /reload command by default.#11990
Closed
Mickey42302 wants to merge 1 commit into
Closed
Conversation
Member
|
This has been discussed many times over the years, and generally, the command is already gated by default, and people are well aware of the implications or just don't care. The diff here is also pointlessly noisy for what it's doing, and would generally not be a feature patch for a thing we add. This PR is also opened against the entirely wrong branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Reposting this to another branch as stated by the github-actions bot.)
I would like to suggest adding a patch which disables the "/reload" command by default. All credit is given to the DivineMC project for this idea.
As stated in the output for the "/reload" command, it is known to cause memory leaks and other issues. Disabling the command by default would encourage users to restart their server instead of reloading it.