Fixes #11921 | Consider off-hand when adding items to player inventory#11993
Closed
niho2 wants to merge 1 commit into
Closed
Fixes #11921 | Consider off-hand when adding items to player inventory#11993niho2 wants to merge 1 commit into
niho2 wants to merge 1 commit into
Conversation
|
Please do not open pull requests from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
addItemmethod inCraftInventorydoesn't consider the off-hand when adding items to a full player inventory. When an item is partially in the off-hand and the rest of the inventory is full, it incorrectly indicates that there's no space available, even though there might be space in the off-hand.Changes
addItemmethod to check if it's a player inventoryTest Cases
Additional Notes