Fix a rare crash with a concurrent modification of a set#12002
Merged
Conversation
lynxplay
reviewed
Jan 22, 2025
lynxplay
approved these changes
Jan 22, 2025
Contributor
lynxplay
left a comment
lynxplay
left a comment
There was a problem hiding this comment.
Beyond the import, LGTM.
emilyy-dev
approved these changes
Jan 22, 2025
Contributor
Author
|
I did not add an import because an other fully qualified import already exists in the file and I didn't want to touch that. Should I remove that aswell? |
Contributor
|
Just leave the other FQN alone, we will be doing a cleanup of these files soonish once we have checkstyle ready on our repos. But new code can already follow that 👍 |
electronicboy
approved these changes
Jan 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix an issue introduced in CraftBukkit 5 years ago in fcfcbd3 (how did noone catch this??)
Relevant part of a crash report: https://pastes.dev/cKg6BswffG (1.21.3 server - but it does not matter here)