add method on ItemStack to edit pdc#12022
Merged
Machine-Maker merged 4 commits intoFeb 16, 2025
Merged
Conversation
lynxplay
force-pushed
the
feature/ItemStack-editPdc
branch
from
7244351 to
89ace40
Compare
lynxplay
approved these changes
Feb 8, 2025
electronicboy
approved these changes
Feb 9, 2025
NoahvdAa
reviewed
Feb 9, 2025
Warriorrrr
approved these changes
Feb 15, 2025
Contributor
|
We should open a docs PR to include the changes on the PDC page (thanks Lulu) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ItemStack#editPersistentDataContainer(Consumer<PersistentDataContainer>)which complementsItemStack#getPersistentDataContainerwhich returns a read-only view of the pdc on that stack.The reason the consumer model is needed here is to allow multiple changes to the PDC without having to do lots and lots of copies. If we just had direct
setmethods, it would have to make a full copy on each set.