Fix Water Animal spawn height option for Squids and Dolphins#12045
Merged
Conversation
electronicboy
approved these changes
Jan 30, 2025
Member
electronicboy
left a comment
electronicboy
left a comment
There was a problem hiding this comment.
I ponder if these should replace initialisation rather than overriding them almost immediately, but, otherwise, from a quick look, lgtm
Contributor
Author
I was thinking about that myself, but WaterAnimal.java has it like that so I decided not to change it 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 1.21.2 when squids and dolphins got baby variants they were moved from WaterAnimal to AgeableWaterCreature, but the Paper water animal spawn configuration code wasn't updated there.
We found this out when squids didn't spawn in our custom map with a custom sea level, even though it was configured.