Fix vanilla map decorations sending when not dirty#12098
Merged
lynxplay merged 1 commit intoFeb 12, 2025
Conversation
lynxplay
approved these changes
Feb 12, 2025
Y2Kwastaken
pushed a commit
to Y2Kwastaken/Paper
that referenced
this pull request
Feb 16, 2025
Sayakie
added a commit
to InstellarMC/Stellar
that referenced
this pull request
Aug 22, 2025
See PaperMC/Paper#12098 chery-picked from PaperMC/Paper@1be2e5f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11677
As a fix for custom maps not being able to affect the dirtyDecorations field here, CB seems to have simply ignored this field entirely for all maps.
This fix restores vanilla behavior while still allowing custom maps to be updated, reducing the amount of map data packets that get sent for vanilla maps.