Fix disable-tripwire-updates option not cancelling tripwire hook updates

[Dqu1J]

Fixes #12127

Currently the disable-tripwire-updates has a bug, it does NOT cancel updates from tripwire hook blocks, which change the attached state property of the tripwire.

This PR fixes this by blocking the calculateState method inside TripWireHookBlock from running.

This is justified as the methods only functionality is:

• Checking nearby blocks to find a correct tripwire line
• Setting attached appropriately
• Also managing redstone signals and firing events related to them (which already never happens when disable-tripwire-updates is on as the tripwires never get powered)

TLDR it only does block updates and nothing else, half of which are already not being ran with disable-tripwire-updates, hence I think the best solution is to just cancel the entire method.

[lynxplay]

Welcome to paper 🎉

Thank you for the PR!
I am a bit unsure on cancelling the entire method here.
We are only preventing updates to tripwires, not to the hooks.
Additionally, if something else ever happens in this method in the future, this change would make it very difficult for us to spot that during a version update.

Does moving this check down to the actual update of the tripwire also solve the issue correctly? (I'd imagine so)

[Dqu1J]

Thanks for the review @lynxplay

I moved the check down to the part of code that updates the block, and ensured it only runs for tripwire and not tripwire hooks.

It still does function correctly like that and the tripwire doesn't get updated (all fields are false).

Though the hook now sets attached to true if it found a valid tripwire line when placed and doesn't update afterwards unless the other hook is broken. This might seem a little inconsistent, tell me if I should cancel updating specifically the attached property for the hook too (by removing the first condition inside the if statement). Just mentioning it, I don't know if it's a concern or not. Other than that all is good. 👍

[lynxplay]

Thanks for the quick response!
I think that is fine, the tripwire hooks are not part of the cancelled update, even if the resulting state looks fine.
Complete nitpick on my end, but can you just move the if statement directly infront of the setBlock line.
E.g.

if (!config.disableUpdatesTripWire) level.setBlock(blockPos1,....) // Paper - rest of comment

That way, in future updates, the patch fails to apply if the setBlock line there changes and we can correct it.
Beyond that, LGTM

[Dqu1J]

Done that @lynxplay

Thank you again for the feedback & swift responses ❤️

[Dqu1J]

yay 🎉🎉🎉🎉🎉
thank you thank you