Prevent creating itemstack with more than 99 amount#12214
Conversation
ghost
self-requested a review
as a
Author
|
I assume there used to be an upper bound of 64 but when 1.20.5 came out it was removed because someone wasn't sure what the new max item amount limit was |
Doc94
reviewed
Mar 2, 2025
| public static @NotNull ItemStack of(final @NotNull Material type, final int amount) { | ||
| Preconditions.checkArgument(type.asItemType() != null, type + " isn't an item"); | ||
| Preconditions.checkArgument(amount > 0, "amount must be greater than 0"); | ||
| Preconditions.checkArgument(amount > 99, "amount must be no greater than 99"); |
Member
There was a problem hiding this comment.
Currently you only allow over 99 in amount
Suggested change
| Preconditions.checkArgument(amount > 99, "amount must be no greater than 99"); | |
| Preconditions.checkArgument(amount <= 99, "amount must be no greater than 99"); |
Member
|
Maybe can be good add the range annotation to the amount. Also docs missing mention the limit |
Contributor
|
See #12213 (comment) |
github-project-automation
Bot
moved this from Awaiting review
to Closed
in Paper PR Queue
Member
|
A big issue is that many plugins end up doing stuff like using an oversized stack amount in order to let the server deal with splitting it out, we couldn't change such behaviour without breaking a whole host of plugins |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of blowing up later (minecraft limits item stack amount between 1 and 99 inclusive)
Fixes #12213