Player - Expose player score#12243
Merged
Machine-Maker merged 3 commits intoPaperMC:mainfrom Mar 8, 2025
Merged
Conversation
Member
|
I don't think we need increase. Get/set seems fine since this really won't be used frequently enough. LGTM |
Owen1212055
reviewed
Mar 8, 2025
Owen1212055
approved these changes
Mar 8, 2025
github-project-automation
bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
kennytv
approved these changes
Mar 8, 2025
Machine-Maker
approved these changes
Mar 8, 2025
github-project-automation
bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to expose NMS
Player#getScore()and its derivatives.This score is show in the death screen of the player.
The name was suggested/discussed with @Owen1212055 on discord.
Chose to use
get/setDeathScreenScoreto prevent confusion/collision with Scoreboard/ObjectivegetScore()Credit goes to Owen for the idea.
(Could have sworn this was already in the API, but nope)