Skip to content

Simplify custom payload handling#12347

Merged
kennytv merged 1 commit into
mainfrom
chore/cleanup-c
Mar 27, 2025
Merged

Simplify custom payload handling#12347
kennytv merged 1 commit into
mainfrom
chore/cleanup-c

Conversation

@kennytv
Copy link
Copy Markdown
Member

@kennytv kennytv commented Mar 27, 2025

No description provided.

@kennytv kennytv requested a review from a team as a code owner March 27, 2025 13:03
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Mar 27, 2025
@github-project-automation github-project-automation Bot moved this from Awaiting review to Awaiting final testing in Paper PR Queue Mar 27, 2025
@kennytv kennytv merged commit 9b1798d into main Mar 27, 2025
@kennytv kennytv deleted the chore/cleanup-c branch March 27, 2025 13:22
@github-project-automation github-project-automation Bot moved this from Awaiting final testing to Merged in Paper PR Queue Mar 27, 2025
AfonsoMendoncaJacinto pushed a commit to AfonsoMendoncaJacinto/Paper that referenced this pull request Mar 28, 2025
@WouterGritter
Copy link
Copy Markdown

Is it papers goal to maintain a persistent/reliable api for internal minecraft classes like these? My team is working on a plugin that calls the data() method on this record and it broke after this commit. The fix is trivial with the use of reflection, but it's still not great having a plugin fail after a seemingly small and trivial change.

@lynxplay
Copy link
Copy Markdown
Contributor

lynxplay commented Apr 4, 2025

No. Internals change whenever we see fit. There is 0 guarantee internal fields/methods/classes remain the same at all at any point in time.
The API for this behaviour is the plugin messaging API, which remained stable.
Internals are not API and do not have stability guarantees between versions or even builds.

//edit: If you have an actual usecase for using this specific internal bit over the plugin messaging API, feel free to share that in a feature request and we can look at exposing an API capability for you so you don't have to use internals.

ShaneBeee pushed a commit to ShaneBeee/Paper that referenced this pull request Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

4 participants