Feat/snbt stack serialisation#12363
Merged
Merged
Conversation
Contributor
|
Welcome to paper 🥳 It appears you commit / generate a whole slew of completely unrelated and invalid changes. edit: Thank you! I look forward to more contributions from you in the future! |
8746259 to
95d1e63
Compare
Contributor
|
Generally in favour of a schema version, the name |
Member
Author
|
Yea, I just wasn't sure if I go for paper:schema_version or just s..._v... or what, so, figured I'd push before I went to go bed or be productive |
9540f6f to
9742f95
Compare
MiniDigger
approved these changes
Apr 12, 2025
kennytv
approved these changes
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a PR because I generally forgot to and we might want more discussion on this;
I am planning to add an "sv" tag incase we want to change the format here or something, but, this is how this currently looks:
It's worth noting that I referenced the vanilla codec for what to serialise, and followed the logic which follows and adds the DV onto that; There was maybe a talk of extracting out the top layer of components;
I generally want to avoid any stupid amounts of translating this as much as possible, but, may be willing to concede on this given that the top layer will basically always be a tag, note that all component values are strings, because json, this aspect will be non-negotiable