Fix floating warning log when the kick event is canceled#12374
Merged
Conversation
dawon
reviewed
Apr 1, 2025
Contributor
|
I think we should additionally reset aboveGroundTickCount when the server attempts to disconnect a player to prevent the event from being spammed |
Contributor
Possibly, tho in a separate PR 👍 |
lynxplay
approved these changes
Apr 22, 2025
github-project-automation
Bot
moved this from PR Party candidate
to Awaiting final testing
in Paper PR Queue
github-project-automation
Bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the floating kick log is sent before the
PlayerKickEventis fired, resulting in incorrect and potentially spammy logging when the event is properly cancelled. This PR fixes the issue by moving the logging to be sent after the event logic.