Expand PotionMeta Api to allow getting effective potion colour and effects#12390
Merged
Conversation
kennytv
reviewed
Apr 12, 2025
kennytv
approved these changes
Apr 22, 2025
github-project-automation
Bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
lynxplay
reviewed
Apr 25, 2025
| * @return the visible colour | ||
| */ | ||
| @Contract(pure = true) | ||
| Color resultingColor(); |
Contributor
There was a problem hiding this comment.
Any reason for this to not be named the same as "effective colour" in the PotionMeta?
Contributor
Author
There was a problem hiding this comment.
I don't believe so.
I think it came from PotionMeta having just getColor vs the data component having them as customColor, where there might be some confusion.
but one or the other is fine
lynxplay
force-pushed
the
feat/potion-effective-colour
branch
from
027af76 to
895fcfd
Compare
lynxplay
force-pushed
the
feat/potion-effective-colour
branch
from
895fcfd to
561df2d
Compare
lynxplay
approved these changes
May 2, 2025
Owen1212055
approved these changes
May 2, 2025
github-project-automation
Bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.