Expose block, entity and flag context to PlayerPickItemEvent#12425
Conversation
Enhanced event to include associated block, entity, and data flag.
|
Maybe this should just be separate events from an abstract class |
|
Initially I had the same idea, but I wasn't sure how backwards compat would work |
To answer my own question, yes the event is still called |
|
I made the PlayerPickItemEvent abstract, would that cause issues with plugins that listen to the event? |
lynxplay
left a comment
There was a problem hiding this comment.
A little on the fence regarding the naming for PlayerPickEntityEvent, as it does not really convey that the player is picking an item by clicking the entity.
It instead sounds a bit like the player is picking an entity itself (somehow). Open for naming changes but, if team is fine with this, also down with merging this this weekend.
|
This now requires a BlockPos/Entity be passed to the tryPickItem method and gets rid of the old signature. Could this be reviewed as I and others have relied on the method without a relevant BlockPos or Entity? |
Enhanced event to include associated block, entity, and data flag.