fix: Improve bStats metrics reliability and error handling#12514
Closed
AtomicElectronCreates wants to merge 1 commit into
Closed
fix: Improve bStats metrics reliability and error handling#12514AtomicElectronCreates wants to merge 1 commit into
AtomicElectronCreates wants to merge 1 commit into
Conversation
Member
|
This PR is impossible to review because of the amount of unrelated changes in it and most of the actual changes are questionable. In general it looks like "A"I" slop. Please refrain from opening such PRs in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the Metrics.java file by:
Properly closing resources with try-with-resources
Adding null checks with Objects.requireNonNull()
Better error handling for config file saving
Safer thread cleanup on shutdown
Atomic file writes for config
More robust HTTP connection handling