Skip to content

Replace legacy Maven resolver dependencies with maven-resolver-supplier-mvn3#12519

Closed
DerMistkaefer wants to merge 1 commit into
PaperMC:mainfrom
DerMistkaefer:feature/maven-resolver-supplier
Closed

Replace legacy Maven resolver dependencies with maven-resolver-supplier-mvn3#12519
DerMistkaefer wants to merge 1 commit into
PaperMC:mainfrom
DerMistkaefer:feature/maven-resolver-supplier

Conversation

@DerMistkaefer
Copy link
Copy Markdown

This PR replaces the following deprecated Maven resolver dependencies:

compileOnly("org.apache.maven.resolver:maven-resolver-connector-basic:1.9.18")
compileOnly("org.apache.maven.resolver:maven-resolver-transport-http:1.9.18")

with:

compileOnly("org.apache.maven.resolver:maven-resolver-supplier-mvn3:2.0.8")

Rationale:
The new maven-resolver-supplier-mvn3 module encapsulates the default resolver setup for Maven environments and provides a cleaner and more modern way to integrate Maven resolution logic.

Code changes:

  • Dependencies updated
  • Internal resolver setup adjusted to use the MavenResolverSupplier from the new dependency
  • Add the commons-lang3 dependency because this where transitive from the removed

This simplifies dependency management and reduces direct reliance on individual connector/transport components.

Let me know if additional adjustments are needed.

@DerMistkaefer DerMistkaefer requested a review from a team as a code owner May 3, 2025 20:48
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue May 3, 2025
@mbax
Copy link
Copy Markdown
Contributor

mbax commented May 3, 2025

Are there any breaking changes that could be exposed to users, going across major versions (1 to 2)? Like, plugins need to provide Dependency and RemoteRepository at the very least. Did anything change in any constructors/getters/static methods/etc that could impact devs?

@DerMistkaefer
Copy link
Copy Markdown
Author

The changes are only internal. Everything that we are exposing are in the maven-resolver-provider dependency.

@DerMistkaefer
Copy link
Copy Markdown
Author

I tested a little bit with the new implementation and transitive dependencies are not downloaded correct.
Currently, I am trying to figure out the reason of this.

@DerMistkaefer DerMistkaefer marked this pull request as draft May 4, 2025 20:38
@github-project-automation github-project-automation Bot moved this from Awaiting review to Closed in Paper PR Queue May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

2 participants