Skip to content

Trying to call Beehive.addEntity with a BlockPopulator leads to IllegalStateException (#12426)#12548

Closed
globau wants to merge 1 commit into
PaperMC:mainfrom
globau:12426-remove-entity-crash
Closed

Trying to call Beehive.addEntity with a BlockPopulator leads to IllegalStateException (#12426)#12548
globau wants to merge 1 commit into
PaperMC:mainfrom
globau:12426-remove-entity-crash

Conversation

@globau
Copy link
Copy Markdown

@globau globau commented May 15, 2025

No description provided.

@globau globau requested a review from a team as a code owner May 15, 2025 16:47
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue May 15, 2025
@Doc94
Copy link
Copy Markdown
Member

Doc94 commented May 15, 2025

I think this not cover the whole fix added in https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/3b4fd5b321f4440a2b3a67f3945739b45e6e687f

@globau globau marked this pull request as draft May 16, 2025 03:14
@globau
Copy link
Copy Markdown
Author

globau commented May 16, 2025

I think this not cover the whole fix added in https://hub.spigotmc.org/stash/projects/SPIGOT/repos/craftbukkit/commits/3b4fd5b321f4440a2b3a67f3945739b45e6e687f

The changes to WorldServer appeared unrelated (eg. why was lightning touched?), and this patch alone was enough to resolve the crash in my local testing. But I'm happy to bring across the Spigot change in full if that's the preferred route.

@globau
Copy link
Copy Markdown
Author

globau commented May 19, 2025

After inspection it looks like all the other changes are already in-tree.

@globau globau marked this pull request as ready for review May 20, 2025 05:37
@electronicboy
Copy link
Copy Markdown
Member

The changes from ServerLevel are not in-tree, the field set was moved

@lynxplay
Copy link
Copy Markdown
Contributor

Closing this in favour of #12588 to properly credit md as commit author.

@lynxplay lynxplay closed this May 24, 2025
@github-project-automation github-project-automation Bot moved this from Awaiting review to Closed in Paper PR Queue May 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

4 participants