Skip to content

Add getPickItem #12552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lynxplay merged 7 commits into from
May 18, 2025
Merged

Add getPickItem #12552

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e1f18fe
Add getPickItem to Entity
Reasonlesss May 9, 2025
6001b22
Use a copy instead of a mirror
Reasonlesss May 16, 2025
59bf7bb
NotNull annotation
Reasonlesss May 16, 2025
bbfb918
remove unused import
Reasonlesss May 16, 2025
9119cbd
remove paper comments
Reasonlesss May 16, 2025
7a2bb34
correct javadoc
Reasonlesss May 16, 2025
5f23608
Rename to itemstack
lynxplay May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions paper-api/src/main/java/org/bukkit/entity/Entity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import org.bukkit.event.entity.CreatureSpawnEvent;
import org.bukkit.event.entity.EntityDamageEvent;
import org.bukkit.event.player.PlayerTeleportEvent.TeleportCause;
import org.bukkit.inventory.ItemStack;
import org.bukkit.material.Directional;
import org.bukkit.metadata.Metadatable;
import org.bukkit.persistence.PersistentDataHolder;
Expand Down Expand Up @@ -538,6 +539,15 @@ final class Holder {
*/
public boolean eject();

/**
* Gets the {@link ItemStack} that a player would select / create (in creative mode)
* when using the pick block action on this entity.
*
* @return item stack result or an empty item stack
*/
@NotNull
ItemStack getPickItemStack();

/**
* Returns the distance this entity has fallen
*
Expand Down
7 changes: 7 additions & 0 deletions paper-server/src/main/java/org/bukkit/craftbukkit/entity/CraftEntity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
import org.bukkit.event.entity.EntityDamageEvent;
import org.bukkit.event.entity.EntityRemoveEvent;
import org.bukkit.event.player.PlayerTeleportEvent.TeleportCause;
import org.bukkit.inventory.ItemStack;
import org.bukkit.metadata.MetadataValue;
import org.bukkit.permissions.PermissibleBase;
import org.bukkit.permissions.Permission;
Expand Down Expand Up @@ -532,6 +533,12 @@ public boolean eject() {
return true;
}

@Override
public ItemStack getPickItemStack() {
net.minecraft.world.item.ItemStack stack = this.getHandle().getPickResult();
return stack == null ? ItemStack.empty() : stack.asBukkitCopy();
}

@Override
public float getFallDistance() {
return (float) this.getHandle().fallDistance;
Expand Down
Loading