feat: expose updateDemand and restock on Villager#12608
Merged
Conversation
Strokkur424
approved these changes
May 31, 2025
NonSwag
reviewed
May 31, 2025
NonSwag
approved these changes
May 31, 2025
electronicboy
approved these changes
May 31, 2025
Member
electronicboy
left a comment
electronicboy
left a comment
There was a problem hiding this comment.
extra import needs yeeting but, not going to not-approve on something somebody can clean up
github-project-automation
Bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
lynxplay
approved these changes
May 31, 2025
Contributor
lynxplay
left a comment
lynxplay
left a comment
There was a problem hiding this comment.
Might benefit from some minecraft.wiki curveballs, like https://minecraft.wiki/w/Villager#Supply_and_demand.
updateDemand specifically. Or maybe a bit of an "intro" as to what demands are.
Doc94
reviewed
May 31, 2025
Contributor
Author
|
Yeah, lemme make the docs a bit more clearer. |
|
that was fast 👍 |
Warriorrrr
approved these changes
Jun 7, 2025
github-project-automation
Bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions are super helpful when creating a plugin to disable the AI of the Villager as they're needed to ensure stock and demand are still calculated like Vanilla.
Restock could always be done manually through the API but demand wasn't possible before this. Tested it with my lobotomizing plugin and it works :)
First time doing an API PR so let me know if it's wrong lol