Port callback command to brigadier#12631
Closed
NonSwag wants to merge 4 commits into
Closed
Conversation
Contributor
|
Wouldn't this be deleted anyway in 1.21.6 as it would use the new custom click event? |
Contributor
Author
|
Did I miss something? What custom click event? Isn't that dialog only? |
Contributor
Contributor
Author
|
Okay yeah can probably close this but let's see what staff thinks about this. |
Member
|
Yep will be migrating to that sometime during the update process. |
github-project-automation
Bot
moved this from Awaiting review
to Closed
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The brigadier version also makes use of the SERVER_ONLY command flag, which doesn't send the command to the client.