Skip to content

Add permission node for "/callback".#12660

Closed
Mickey42302 wants to merge 1 commit into
PaperMC:mainfrom
Mickey42302:callback
Closed

Add permission node for "/callback".#12660
Mickey42302 wants to merge 1 commit into
PaperMC:mainfrom
Mickey42302:callback

Conversation

@Mickey42302
Copy link
Copy Markdown

@Mickey42302 Mickey42302 commented Jun 12, 2025

No description provided.

@Mickey42302 Mickey42302 requested a review from a team as a code owner June 12, 2025 00:34
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Jun 12, 2025
@Malfrador
Copy link
Copy Markdown
Member

Malfrador commented Jun 12, 2025

I am a bit concerned about this, as its API functionality. A plugin would expect its clickable text to work properly, without checking for permissions first. It would be really confusing for users too as its not immediately obvious this permission and command are related to clickable text of some other plugin.

Additionally the command can be replaced in 1.21.6 anyways, as Mojang added a way of adding custom click events that does not rely on commands.

@Machine-Maker
Copy link
Copy Markdown
Member

I don't like this at all. Why would a server want to disable this command for anyone? It just is going to end up breaking plugins that use it.

@Malfrador
Copy link
Copy Markdown
Member

Would setting the permission node to "true" by default for all players prevent that issue?

That would essentially be a requirement, otherwise API would be completely broken unless server owners explicitly give permissions for it.

But I don't really think its worth adding this.
1.21.6 is releasing soon, and the custom click action and its dedicated packet are a much better way of implementing the callback functionality than the command. I would expect the command to get removed as soon as Adventure updates the ClickCallback to that, essentially solving this issue.
And just adding this for 1.21.5/.4 which will soon be unsupported really seems a bit useless.

@github-project-automation github-project-automation Bot moved this from Awaiting review to Closed in Paper PR Queue Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Closed

Development

Successfully merging this pull request may close these issues.

3 participants