Add EntitySpinAttackEvent#12808
Closed
Clexus wants to merge 3 commits into
Closed
Conversation
notTamion
suggested changes
Jul 13, 2025
| * calls {@link org.bukkit.event.entity.EntityDamageByEntityEvent}. | ||
| */ | ||
| @NullMarked | ||
| public class EntitySpinAttackEvent extends EntityEvent implements Cancellable { |
Contributor
There was a problem hiding this comment.
EntityRiptideAttackEvent given we call it riptiding in most other places
Comment on lines
+1549
to
+1550
| + if (entity instanceof LivingEntity livingEntity) { // Paper - move LivingEntity conversion ahead | ||
| + // Paper start - fire EntitySpinAttackEvent |
Contributor
There was a problem hiding this comment.
one paper start comment above the if statement is enough
Contributor
Author
There was a problem hiding this comment.
one paper start comment above the if statement is enough
my repo was broken so I made a new pr #12842
github-project-automation
Bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful when user want to detect "an entity collides with another entity using a trident" or what