Replace compileOnly with implementation for test visibility#12841
Merged
Conversation
electronicboy
approved these changes
Jul 13, 2025
github-project-automation
Bot
moved this from Awaiting review
to Awaiting final testing
in Paper PR Queue
Contributor
|
We should be able to drop the runtimeOnly definitions in the server then (as we are currently duplicating the definition there to actually include the library) |
Machine-Maker
approved these changes
Jul 16, 2025
github-project-automation
Bot
moved this from Awaiting final testing
to Merged
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing tests for
MavenLibraryResolver, it was discovered that the Paper API's transitive Maven resolver dependencies were not available at runtime.This was due to
maven-resolver-connector-basicandmaven-resolver-transport-httpbeing declared with thecompileOnly.