fix: PlayerServerFullCheckEvent#deny not setting the allow flag

[Timongcraft]

No description provided.

[MesuDevastator]

This seems to prevent players from joining in an empty server.

[electronicboy]

That is caused by plugins calling the deny method when they're not actually denying the event

[SunnyCat95]

Well, sadly this issue seems not to be resolved.
#106 is crashing mcMMo and not letting it start by the way

and from at least #105 and #104 nobody except Admin (with * permission) can join!
so with #102 it still works fine..

[electronicboy]

The "fix" here is making the deny method actually deny connections. The issue is that at least 1 plugin was blindly using the deny method to set the message without the intent to actually deny the connection attempt;

Plugins need to call the deny method if they only intend to actually deny the connection

[SunnyCat95]

The "fix" here is making the deny method actually deny connections. The issue is that at least 1 plugin was blindly using the deny method to set the message without the intent to actually deny the connection attempt;

Plugins need to call the deny method if they only intend to actually deny the connection

So I have to find out which plugin is causing this?
Then I rather stay on 102 and so at least also mcMMo is still working (not working anymore from 106 on)^^

it worked totally fine before and with 103 on it got worse, sadly :(
Not sure what I can and should do now to resolve it and getting the newer paper-versions.^^

[Doc94]

You can find plugins using the event fixed using https://docs.papermc.io/paper/reference/commands/#dumplisteners with that can report to authors for handle.

[SwordfishBE]

Also broke my server. This fix should have been considered more carefully. I suspect many users are now experiencing problems.

[masmc05]

You can send the output of the dumplisteners command in discord so someone could help you with this. For example it is already known how to disable the broken feature in essentials as a temporary fix

[MesuDevastator]

io.papermc.paper.event.player.PlayerServerFullCheckEvent
 - RegisteredListener{plugin="Essentials", listener="com.earth2me.essentials.EssentialsPlayerListener$LoginListener1_21@d2db5ab", executor="TimedEventExecutor['MethodHandleEventExecutorTemplate['public void com.earth2me.essentials.EssentialsPlayerListener$LoginListener1_21.onPlayerListFull(io.papermc.paper.event.player.PlayerServerFullCheckEvent)']']", priority="HIGH (3)", ignoringCancelled=false}

In my case, it was caused by EssentialsX, and could be fixed by setting use-custom-server-full-message to false in its config.yml.