Add API for retreiving the itemstack used to launch a projectile#1940
Closed
Spottedleaf wants to merge 6 commits into
Closed
Add API for retreiving the itemstack used to launch a projectile#1940Spottedleaf wants to merge 6 commits into
Spottedleaf wants to merge 6 commits into
Conversation
Contributor
|
Dude, you are terminator! So much PRs |
Contributor
|
It may be beyond the scope of this PR, but it would be very nice (and also consistent) if the equivalent of |
Member
Author
|
That is beyond the scope of this patch |
Fix bug where the launch projectile was the bow for a skeleton instead of the arrow
Spottedleaf
force-pushed
the
arrow-getlaunchitem
branch
from
6d949cc to
c6038f7
Compare
Check for IProjectile in AbstractProjectile
aikar
requested changes
Apr 6, 2019
Member
aikar
left a comment
aikar
left a comment
There was a problem hiding this comment.
since bukkits projectile doesnt match nms's, i rather us not put it on abstract, and use an interface instead and just tack it on the ones it is actually applicable to.
Member
|
Maybe something like LaunchedProjectile? and getLaunchingItem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that we will have to watch out for new projectiles / new code to launch projectiles on updates.
Should resolve #1937