Skip to content

Implement alternative item-despawn-rate#2128

Merged
electronicboy merged 12 commits into
PaperMC:ver/1.14from
kickash32:alternative-item-despawn-rate
Aug 7, 2019
Merged

Implement alternative item-despawn-rate#2128
electronicboy merged 12 commits into
PaperMC:ver/1.14from
kickash32:alternative-item-despawn-rate

Conversation

@kickash32
Copy link
Copy Markdown
Contributor

This implements the feature request of #1710. If enabled, the specified Materials which are dropped as items will despawn at the chose alternate rate. Materials which are not selected will be unaffected regardless.

See #1710 for config setup (in paper.yml)

@kickash32 kickash32 changed the title Create 0399-Implement-alternative-item-despawn-rate.patch Implement alternative item-despawn-rate Jun 3, 2019
Comment thread Spigot-Server-Patches/0399-Implement-alternative-item-despawn-rate.patch Outdated
Comment thread Spigot-Server-Patches/0399-Implement-alternative-item-despawn-rate.patch Outdated
Comment thread Spigot-Server-Patches/0399-Implement-alternative-item-despawn-rate.patch Outdated
@MiniDigger
Copy link
Copy Markdown
Member

thinking more about this, wouldn't it make more sense to have a map with individual despawn rates per material? or would that be overkill?

@kickash32
Copy link
Copy Markdown
Contributor Author

I see no downsides actually

Comment thread Spigot-Server-Patches/0399-Implement-alternative-item-despawn-rate.patch Outdated
kickash32 added 2 commits June 4, 2019 04:28
also using EnumSet
@kickash32
Copy link
Copy Markdown
Contributor Author

Latest commit has added the requested changes.
But would it be worthwhile to use a map instead?

@kickash32
Copy link
Copy Markdown
Contributor Author

kickash32 commented Jun 5, 2019

Added per item config.
Config is now

alt-item-despawn-rate:
      enabled: true
      items:
        COBBLESTONE: 300

Comment thread Spigot-Server-Patches/0399-Implement-alternative-item-despawn-rate.patch Outdated
@kickash32
Copy link
Copy Markdown
Contributor Author

updated for 1.14.4

@CeIebrimbor
Copy link
Copy Markdown

Reason this isn't getting pulled? Seems like an easy, straightforward PR.

@Spottedleaf
Copy link
Copy Markdown
Member

time

Comment thread Spigot-Server-Patches/0406-Implement-alternative-item-despawn-rate.patch Outdated
Comment thread Spigot-Server-Patches/0406-Implement-alternative-item-despawn-rate.patch Outdated
@kickash32
Copy link
Copy Markdown
Contributor Author

Fixed both issues.

Comment thread Spigot-Server-Patches/0406-Implement-alternative-item-despawn-rate.patch Outdated
@electronicboy electronicboy merged commit 8b7952a into PaperMC:ver/1.14 Aug 7, 2019
@kickash32 kickash32 deleted the alternative-item-despawn-rate branch August 7, 2019 21:06
LeonTG pushed a commit to LeonTG/Paper that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants