Guard against serializing mismatching nbt chunk coordinate#2325
Closed
Spottedleaf wants to merge 8 commits into
Closed
Guard against serializing mismatching nbt chunk coordinate#2325Spottedleaf wants to merge 8 commits into
Spottedleaf wants to merge 8 commits into
Conversation
Also print an exception if we fail to load data off disk
DenWav
reviewed
Jul 17, 2019
| + oversizedData = regionfile.getOversizedData(chunkCoordinate.x, chunkCoordinate.z); | ||
| + } catch (Exception ex) {} | ||
| + } catch (Exception ex) { | ||
| + MinecraftServer.LOGGER.error("Failed to read OVERSIZED chunk data for " + chunkCoordinate + " in regionfile " + regionfile.file.toString() + ", ignoring OVERSIZED data", ex); |
Member
There was a problem hiding this comment.
toString() in regionfile.file.toString() is unnecessary, no?
Member
Author
There was a problem hiding this comment.
I've got a habit of explicitly toString()ing objects in concatenation
Member
Author
|
updated to 1.14.4 |
zachbr
approved these changes
Jul 24, 2019
Member
Author
|
merged downstream |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also print an exception if we fail to load data off disk