Skip to content

MC-12211 Comparator Visual Fix and 0-Tick Timing in a Bugged State Fix#2428

Closed
Nickster258 wants to merge 2 commits into
PaperMC:masterfrom
Nickster258:master
Closed

MC-12211 Comparator Visual Fix and 0-Tick Timing in a Bugged State Fix#2428
Nickster258 wants to merge 2 commits into
PaperMC:masterfrom
Nickster258:master

Conversation

@Nickster258
Copy link
Copy Markdown

This resolves the visual glitch mentioned in the Jira report,
while also preventing the comparator from experiencing 0-tick falling edge
timing issues when in the bugged state mentioned in the report.

This instant 0-tick response is undesirable given the erratic and
seemingly unpredictable behavior represented by a comparator in a bugged
state. It is also problematic as a comparator in a bugged state can
schedule tile ticks on itself when it should not.

You can see an example of the before and after behavior here:
IMAGE ALT TEXT HERE

@Tohya1
Copy link
Copy Markdown

Tohya1 commented Aug 9, 2019

should check the eigencraft patch as well

@Nickster258
Copy link
Copy Markdown
Author

should check the eigencraft patch as well

This patch works independently of the eigencraft patch as this only fixes the problematic comparator behavior.

@zachbr
Copy link
Copy Markdown
Contributor

zachbr commented Aug 15, 2019

Fixing visual issues is fine.
Changing redstone behavior to fix an MC bug is not unless its behind a config option.

@Nickster258
Copy link
Copy Markdown
Author

I'll address the configuration option in a new PR against ver/1.14 at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants