MC-12211 Comparator Visual Fix and 0-Tick Timing in a Bugged State Fix#2428
Closed
Nickster258 wants to merge 2 commits into
Closed
MC-12211 Comparator Visual Fix and 0-Tick Timing in a Bugged State Fix#2428Nickster258 wants to merge 2 commits into
Nickster258 wants to merge 2 commits into
Conversation
|
should check the eigencraft patch as well |
Author
This patch works independently of the eigencraft patch as this only fixes the problematic comparator behavior. |
Contributor
|
Fixing visual issues is fine. |
Author
|
I'll address the configuration option in a new PR against ver/1.14 at a later date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves the visual glitch mentioned in the Jira report,
while also preventing the comparator from experiencing 0-tick falling edge
timing issues when in the bugged state mentioned in the report.
This instant 0-tick response is undesirable given the erratic and
seemingly unpredictable behavior represented by a comparator in a bugged
state. It is also problematic as a comparator in a bugged state can
schedule tile ticks on itself when it should not.
You can see an example of the before and after behavior here:
