Add PreparedGrindstoneEvent#3578
Closed
JanTuck wants to merge 0 commit into
Closed
Conversation
Proximyst
approved these changes
Jun 19, 2020
Contributor
Proximyst
left a comment
Proximyst
left a comment
There was a problem hiding this comment.
All but these two rather minor things look great
| +import org.bukkit.Bukkit; | ||
| +import org.bukkit.craftbukkit.inventory.CraftItemStack; | ||
| +// Paper end | ||
| + |
| + event.setResult(CraftItemStack.asBukkitCopy(ItemStack.a)); // Paper - Get result | ||
| } | ||
|
|
||
| + Bukkit.getPluginManager().callEvent(event); // Paper Event Call |
Contributor
There was a problem hiding this comment.
aikar
reviewed
Jun 20, 2020
| boolean flag2 = !itemstack.isEmpty() && itemstack.getItem() != Items.ENCHANTED_BOOK && !itemstack.hasEnchantments() || !itemstack1.isEmpty() && itemstack1.getItem() != Items.ENCHANTED_BOOK && !itemstack1.hasEnchantments(); | ||
|
|
||
| if (itemstack.getCount() > 1 || itemstack1.getCount() > 1 || !flag1 && flag2) { | ||
| - this.resultInventory.setItem(0, ItemStack.a); |
Member
There was a problem hiding this comment.
There are many places like this where the event result is set but the function returns early. I don't think this is firing the event here due to the early return.
Contributor
Author
There was a problem hiding this comment.
I see, that was an oversight on my part
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First pull request, hopefully it doesn't suck ass.