Return chat component with empty text instead of throwing exception.#3843
Closed
CDFN wants to merge 3 commits into
Closed
Return chat component with empty text instead of throwing exception.#3843CDFN wants to merge 3 commits into
CDFN wants to merge 3 commits into
Conversation
Proximyst
suggested changes
Jul 7, 2020
aikar
requested changes
Jul 7, 2020
Proximyst
added
status: rebase required
type: bug
chickeneer
suggested changes
Sep 5, 2020
| * Get the title of this inventory window. | ||
| * | ||
| - * @return The title. | ||
| + * @return The title or empty string when title is null. |
Contributor
There was a problem hiding this comment.
This should get a // Paper tag on it. Just at the end of the line.
Contributor
There was a problem hiding this comment.
The javadoc is HTML, so:
Suggested change
| + * @return The title or empty string when title is null. | |
| + * @return The title or empty string when title is {@code null}. <!-- Paper --> |
Proximyst
approved these changes
Nov 1, 2020
electronicboy
approved these changes
Dec 2, 2020
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3328