Added more Options to Paper#4068
Conversation
|
At the very least compile your changes before submitting the PR. Also, please split these changes into separate PRs for easing the merger's life in selecting which are accepted and which aren't. Join our Discord if you'd like more help, as there are still several issues you need to fix. |
I missed out one line and everything broke :/ As for the PRs I was kind of afraid of spamming several threads into the PR section, I'll try doing that if I have time I am in the Paper Discord, by the way |
|
Readding legacy gamemode ids has nothing to do in a Paper patch (and your spacing is still very much bork)🥶 |
|
When seeing someone use spaces instead of tabs 👀 |
|
Ivan what are you on about? Any sane person uses spaces instead of tabs. |
|
|
|
|
Ivan IJ defaults to converting tabs to 5 or so spaces. |
Looks like I need to change settings |
CDFN
left a comment
CDFN
left a comment
There was a problem hiding this comment.
I'm sure 0551 won't get merged - it shouldn't be new patch for changing config. One feature = one commit - it'll allow you to keep patches clean.
If I'm wrong in any review please correct me =)
| @@ -0,0 +1,29 @@ | |||
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | |||
| From: BuildTools <unconfigured@null.spigotmc.org> | |||
| @@ -0,0 +1,41 @@ | |||
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | |||
| From: BuildTools <unconfigured@null.spigotmc.org> | |||
| @@ -0,0 +1,23 @@ | |||
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | |||
| From: BuildTools <unconfigured@null.spigotmc.org> | |||
| @@ -0,0 +1,30 @@ | |||
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | |||
| From: BuildTools <unconfigured@null.spigotmc.org> | |||
| - return 0; | ||
| - } else { | ||
| int i = this.e; | ||
| - |
There was a problem hiding this comment.
No need to remove this line (keep minimal diff as it is only possible0
| return this.l; | ||
| } | ||
|
|
||
| + public void setOPLevel(GameProfile profile, int level) { |
There was a problem hiding this comment.
Keep convention - in method below you have addOp, here you have setOPLevel.
| } | ||
| + | ||
| + @Override | ||
| + public int getOPLevel() { |
| + } | ||
| + | ||
| + @Override | ||
| + public void setOPLevel(int level) { |
| } | ||
| + | ||
| + @Override | ||
| + public int getOPLevel() { |
| + } | ||
| + | ||
| + @Override | ||
| + public void setOPLevel(int level) { |
There was a problem hiding this comment.
Further you have more OPs, won't mark it but change it too.
7 participants
Changelist is the same as #4067 but this time it's even more polished and every change is in an individual commit
Sorry if I appear like an idiot this is pretty much the first time I've tried a Pull Request