Skip to content

fix #4144#4170

Merged
aikar merged 2 commits into
PaperMC:masterfrom
jpenilla:bugfix/4144
Aug 30, 2020
Merged

fix #4144#4170
aikar merged 2 commits into
PaperMC:masterfrom
jpenilla:bugfix/4144

Conversation

@jpenilla
Copy link
Copy Markdown
Member

@jpenilla jpenilla commented Aug 21, 2020 •
edited
Loading

fixes #4144

@jpenilla jpenilla requested a review from a team as a code owner August 21, 2020 19:38
Proximyst
Proximyst previously approved these changes Aug 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Proximyst Proximyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nitpick, otherwise LGTM.

Comment thread Spigot-API-Patches/0053-PlayerAttemptPickupItemEvent.patch Outdated
@Chew
Copy link
Copy Markdown
Contributor

Chew commented Aug 21, 2020

Easy PR someone took up 🎉

Prof-Bloodstone
Prof-Bloodstone reviewed Aug 21, 2020
View reviewed changes
Comment thread Spigot-API-Patches/0053-PlayerAttemptPickupItemEvent.patch Outdated
electronicboy
electronicboy reviewed Aug 21, 2020
View reviewed changes
Comment thread Spigot-API-Patches/0053-PlayerAttemptPickupItemEvent.patch Outdated
@jpenilla
Copy link
Copy Markdown
Member Author

jpenilla commented Aug 21, 2020 •
edited
Loading

Impl is copied from 0052-PlayerPickupItemEvent-setFlyAtPlayer.patch

Also see billys comments here: #4144 (comment)
he basically instructed me how to fix this

edit: The behavior which is introduced by this change makes it so that it matches the javadocs: https://papermc.io/javadocs/paper/1.16/org/bukkit/event/player/PlayerAttemptPickupItemEvent.html#setFlyAtPlayer-boolean-
right now it is currently broken if your going by javadoc, and has been for a while.
this is outlined in the linked issue

@jpenilla jpenilla requested a review from electronicboy August 21, 2020 20:31
@Proximyst Proximyst added the type: bug Something doesn't work as it was intended to. label Aug 24, 2020
@jpenilla jpenilla changed the base branch from progress/1.16.2 to master August 25, 2020 04:42
@jpenilla jpenilla changed the base branch from master to progress/1.16.2 August 25, 2020 04:43
@jpenilla jpenilla changed the base branch from progress/1.16.2 to master August 25, 2020 05:17
@Proximyst Proximyst linked an issue Aug 29, 2020 that may be closed by this pull request
PlayerAttemptPickupItemEvent setFlyAtPlayer will not be set to false when cancelling the event #4144
Closed
@aikar aikar merged commit 414e5e1 into PaperMC:master Aug 30, 2020
@Strahilchu Strahilchu mentioned this pull request Sep 22, 2020
Closed
@jpenilla jpenilla deleted the bugfix/4144 branch May 9, 2021 02:56
LeonTG pushed a commit to LeonTG/Paper that referenced this pull request May 17, 2026
@jpenilla
fix PaperMC#4144 (PaperMC#4170)
5532c4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aikar aikar aikar approved these changes

@electronicboy electronicboy Awaiting requested review from electronicboy

+2 more reviewers

@Prof-Bloodstone Prof-Bloodstone Prof-Bloodstone left review comments

@Proximyst Proximyst Proximyst left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type: bug Something doesn't work as it was intended to.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PlayerAttemptPickupItemEvent setFlyAtPlayer will not be set to false when cancelling the event

6 participants

@jpenilla @Chew @aikar @electronicboy @Proximyst @Prof-Bloodstone