Add StructureLocateEvent#4333
Merged
Merged
Conversation
mikroskeem
suggested changes
Sep 16, 2020
electronicboy
requested changes
Oct 14, 2020
BillyGalbreath
previously approved these changes
Oct 14, 2020
Proximyst
suggested changes
Nov 14, 2020
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
These changes LGTM. This should be merged. |
Signed-off-by: MiniDigger <admin@minidigger.me>
Member
|
thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a StructureLocateEvent, which fires when the /locate command is used, when an eye of ender is used, explorer maps are opened, etc.
The event is Cancellable, and also contains getters and setters for the search radius, origin location, structure type, whether to only search unexplored structures, and the resulting location (result location can only be set, as the event fires before the structure is actually located. If developers wish to manipulate the result, they may use
StructureLocateEvent#setResult(Location)and set the result. Setting the result skips the actual check)This is useful in custom world generators, where developers may wish to implement their own structures.
It is also useful for making Eyes of Ender point to igloos, if that's your sort of thing.