Fix item locations dropped from campfires #4611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proximyst
previously approved these changes
Oct 4, 2020
electronicboy
previously approved these changes
Oct 6, 2020
Member
electronicboy
left a comment
electronicboy
left a comment
There was a problem hiding this comment.
Accepting, but, if this is the issue, this makes me somewhat wear of dropItem in general, is this just bad luck on the basis of the "random" of the code causing it to clip in the campfire block itself?
MiniDigger
dismissed stale reviews from electronicboy and Proximyst
via
6429b3b
Member
|
@limbo-app ready |
limbo-app
previously approved these changes
Oct 9, 2020
limbo-app
left a comment
limbo-app
left a comment
There was a problem hiding this comment.
Pull request automatically approved for merging - a core team member has previously approved this pull request.
aikar
approved these changes
Oct 20, 2020
Member
|
thanks, sorry for taking so long, looked at this last week and forgot to merge |
electronicboy
added a commit
that referenced
this pull request
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4259 by not flooring the blockposition among other weirdness