Skip to content

Fix lead dupe#4938

Merged
Proximyst merged 1 commit into
PaperMC:masterfrom
webcrawls:fix-lead-dupe
Dec 25, 2020
Merged

Fix lead dupe#4938
Proximyst merged 1 commit into
PaperMC:masterfrom
webcrawls:fix-lead-dupe

Conversation

@webcrawls
Copy link
Copy Markdown

This patch fixes the Paper lead dupe. ok pls give contrib role now plsthxty (NOT /s.)

@webcrawls webcrawls requested a review from a team as a code owner December 25, 2020 06:31
@tadhgboyle
Copy link
Copy Markdown

LGTM, thanks.

JRoy
JRoy previously approved these changes Dec 25, 2020
Titaniumtown
Titaniumtown previously approved these changes Dec 25, 2020
Copy link
Copy Markdown

@Titaniumtown Titaniumtown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@webcrawls webcrawls dismissed stale reviews from Titaniumtown and JRoy via 753d2e5 December 25, 2020 06:34
Titaniumtown
Titaniumtown previously approved these changes Dec 25, 2020
@webcrawls
Copy link
Copy Markdown
Author

@Toshimichi0915
Copy link
Copy Markdown
Contributor

So, you tested your code?
All you did was to copy & paste my code. And you didn't even try to test the code you submitted

@webcrawls
Copy link
Copy Markdown
Author

So, you tested your code?
All you did was to copy & paste my code. And you didn't even try to test the code you submitted

I don't feel like getting in a stupid quarrel over this - jroy asked me to resubmit this PR, so I did. I am happy to close this if you'd like me to.

Proximyst
Proximyst previously approved these changes Dec 25, 2020
Copy link
Copy Markdown
Contributor

@Proximyst Proximyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested & works. Will fixup upon merge

@Proximyst Proximyst dismissed stale reviews from Titaniumtown and themself via f658781 December 25, 2020 11:37
@Proximyst Proximyst merged commit 2438838 into PaperMC:master Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants