Added PlayerAngerPiglinByInteractionEvent#5004
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
Member
|
I think I would remove "Interact" from the name, PlayerAngerPiglin(s?)Event sounds better |
Member
Author
|
@MiniDigger I originally had it named exactly that, but theres more than 1 way to anger piglins. So I wanted this event to be specific to angering by interacting with/destroying specific blocks. |
Member
|
can we make this event cover all anger reasons? :D |
Member
Author
|
I think that's already covered by other events? |
aurorasmiles
added
status: accepted
Machine-Maker
force-pushed
the
feature/PlayerInteractAngerPiglinEvent
branch
from
3bbe48a to
eb7fb18
Compare
Member
Author
|
|
kennytv
requested changes
Apr 24, 2021
Machine-Maker
force-pushed
the
feature/PlayerInteractAngerPiglinEvent
branch
from
eb7fb18 to
4dcc46c
Compare
kashike
requested changes
Apr 28, 2021
Machine-Maker
force-pushed
the
feature/PlayerInteractAngerPiglinEvent
branch
from
4dcc46c to
4dcab1a
Compare
Machine-Maker
changed the title
Machine-Maker
force-pushed
the
feature/PlayerInteractAngerPiglinEvent
branch
from
4dcab1a to
88a5486
Compare
Machine-Maker
force-pushed
the
feature/PlayerInteractAngerPiglinEvent
branch
from
88a5486 to
13ed04e
Compare
Member
Author
|
Rebased for 1.17.1 |
Proximyst
approved these changes
Jul 9, 2021
jpenilla
requested changes
Jul 9, 2021
Machine-Maker
force-pushed
the
feature/PlayerInteractAngerPiglinEvent
branch
from
13ed04e to
725f408
Compare
2 tasks
jpenilla
requested changes
Jul 30, 2021
Machine-Maker
force-pushed
the
feature/PlayerInteractAngerPiglinEvent
branch
from
725f408 to
368b19d
Compare
Machine-Maker
force-pushed
the
feature/PlayerInteractAngerPiglinEvent
branch
from
368b19d to
94d0a4e
Compare
Owen1212055
approved these changes
Dec 27, 2022
Member
Owen1212055
left a comment
Owen1212055
left a comment
There was a problem hiding this comment.
look good,
although some of the names of the methods in the event could use some work.
isOpenBlock
kennytv
approved these changes
Dec 28, 2022
| + * | ||
| + * @return true if open a block, false if breaking a block | ||
| + */ | ||
| + public boolean isOpenBlock() { |
Member
There was a problem hiding this comment.
The method name sounds like the block is already open
Machine-Maker
force-pushed
the
feature/PlayerInteractAngerPiglinEvent
branch
from
94d0a4e to
deba453
Compare
lynxplay
force-pushed
the
feature/PlayerInteractAngerPiglinEvent
branch
from
deba453 to
cc79115
Compare
|
Wow, the pull from 4 years ago, I think we can delete some outdated pulls |
kennytv
added
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4828