Skip to content

Add missing effects#5005

Merged
MiniDigger merged 1 commit into
PaperMC:masterfrom
MrIvanPlays:patch/missing-effects
Jan 30, 2021
Merged

Add missing effects#5005
MiniDigger merged 1 commit into
PaperMC:masterfrom
MrIvanPlays:patch/missing-effects

Conversation

@MrIvanPlays
Copy link
Copy Markdown
Contributor

@MrIvanPlays MrIvanPlays commented Jan 5, 2021

Fixes SPIGOT-6249

@MiniDigger
Copy link
Copy Markdown
Member

I actually planned upstreaming that (hence why I opened the issue upstream).
do you mind PRing that upstream? since its just bukkit is should be painless.

@MrIvanPlays
Copy link
Copy Markdown
Contributor Author

MrIvanPlays commented Jan 5, 2021

guess ill sign the cla and attempt upstreaming...
if it works ill close this

EDIT: ok no im definitely not signing that shit... getting my phone number and address doxed... no thanks

@MiniDigger
Copy link
Copy Markdown
Member

would you mind me taking this upstream? (keeping commit author and shit)

@Proximyst
Copy link
Copy Markdown
Contributor

md_5 has previously stated he would not accept that. Ivan would need to give you the rights to the code.

@MrIvanPlays
Copy link
Copy Markdown
Contributor Author

would you mind me taking this upstream? (keeping commit author and shit)

no problem. it goes without asking 🤣

@MiniDigger
Copy link
Copy Markdown
Member

what so I can't commit under ivans name cause clearly MIT isn't permissive enough?

@MrIvanPlays
Copy link
Copy Markdown
Contributor Author

@MiniDigger whats the progress on porting this to spigot?
if there's none you can always merge this :)

@MiniDigger
Copy link
Copy Markdown
Member

md told me to not submit that contribution 🤷

@MrIvanPlays
Copy link
Copy Markdown
Contributor Author

then just merge that

@MiniDigger MiniDigger force-pushed the patch/missing-effects branch from 8fd3ea0 to f835283 Compare January 30, 2021 20:50
@MiniDigger MiniDigger merged commit 0514fc4 into PaperMC:master Jan 30, 2021
@MiniDigger
Copy link
Copy Markdown
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants