Add missing effects#5005
Conversation
|
I actually planned upstreaming that (hence why I opened the issue upstream). |
|
guess ill sign the cla and attempt upstreaming... EDIT: ok no im definitely not signing that shit... getting my phone number and address doxed... no thanks |
|
would you mind me taking this upstream? (keeping commit author and shit) |
|
md_5 has previously stated he would not accept that. Ivan would need to give you the rights to the code. |
no problem. it goes without asking 🤣 |
|
what so I can't commit under ivans name cause clearly MIT isn't permissive enough? |
|
@MiniDigger whats the progress on porting this to spigot? |
|
md told me to not submit that contribution 🤷 |
|
then just merge that |
8fd3ea0 to
f835283
Compare
|
thanks! |
Fixes SPIGOT-6249