Skip to content

CommandFunction API#5021

Closed
Machine-Maker wants to merge 1 commit into
PaperMC:masterfrom
Machine-Maker:feature/CommandFunctions-API
Closed

CommandFunction API#5021
Machine-Maker wants to merge 1 commit into
PaperMC:masterfrom
Machine-Maker:feature/CommandFunctions-API

Conversation

@Machine-Maker
Copy link
Copy Markdown
Member

No description provided.

@Machine-Maker Machine-Maker requested a review from a team as a code owner January 7, 2021 07:55
@stale
Copy link
Copy Markdown

stale Bot commented Mar 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Copy Markdown
Member

@MiniDigger MiniDigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread Spigot-Server-Patches/0648-CommandFunction-API.patch Outdated
Comment thread Spigot-Server-Patches/0648-CommandFunction-API.patch Outdated
@MiniDigger MiniDigger added the status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added. label Mar 8, 2021
@Machine-Maker Machine-Maker force-pushed the feature/CommandFunctions-API branch from d488d2d to 78ab089 Compare March 22, 2021 02:22
@Machine-Maker
Copy link
Copy Markdown
Member Author

Rebased after the NMS repackage

@kennytv
Copy link
Copy Markdown
Member

kennytv commented Apr 30, 2021

I can't really think of good use cases for this, could you give examples for that?

@MiniDigger
Copy link
Copy Markdown
Member

MiniDigger commented Apr 30, 2021

executing or inspecting mcfunctions provided by datapacks. IE, you got some datapack from pmc that spawns some structure and want to call that from a plugin?

@Machine-Maker
Copy link
Copy Markdown
Member Author

Yeah, mini laid out a decent one. It’s just part of a larger goal to incorporate all or most of the whole data packs/advancements packs, into the api.

@Machine-Maker Machine-Maker force-pushed the feature/CommandFunctions-API branch from 78ab089 to 5f2739d Compare May 24, 2021 18:48
@Machine-Maker Machine-Maker requested a review from a team as a code owner May 24, 2021 18:48
@Machine-Maker Machine-Maker force-pushed the feature/CommandFunctions-API branch from 5f2739d to 2509cb3 Compare May 24, 2021 18:50
@Machine-Maker Machine-Maker force-pushed the feature/CommandFunctions-API branch from 2509cb3 to 5c92ee6 Compare July 9, 2021 06:03
@Machine-Maker
Copy link
Copy Markdown
Member Author

Rebased for 1.17.1

Copy link
Copy Markdown
Contributor

@Proximyst Proximyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very knowledgeable on the whole datapack stuff, so someone else should also have a look

@Machine-Maker
Copy link
Copy Markdown
Member Author

I made some somewhat significant changes to this, so it probably has to be reviewed again.

@Machine-Maker Machine-Maker force-pushed the feature/CommandFunctions-API branch from c1afc04 to 73b9458 Compare November 3, 2023 19:44
@Machine-Maker
Copy link
Copy Markdown
Member Author

Updated for 1.20.2. I removed the addition to the paper-mojangapi and just left a comment that we should expose the ParseResults of the function once mojang's brigadier is exposed in the API.

@Warriorrrr Warriorrrr moved this from Awaiting review to Waiting For Author in Paper PR Queue Mar 5, 2025
@kennytv kennytv added the pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch label Mar 23, 2025
@kennytv kennytv deleted the branch PaperMC:master March 23, 2025 19:15
@kennytv kennytv closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch pre-softspoon status: accepted Disputed bug is accepted as valid or Feature accepted as desired to be added.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants