Fix PlayerItemConsumeEvent cancelling (fixes #4682)#5383
Merged
Conversation
electronicboy
approved these changes
Apr 10, 2021
Member
|
needs rebasing, but, want this mergarino'd soon |
Contributor
Author
|
This is rebased to be mergeable at the moment. In general, just runs the risk of needing an updated patch number if not acted on. Low Diff patch, so low likeliness of conflicts. |
zachbr
approved these changes
Apr 17, 2021
Member
|
I know, I just generally prefer to avoid merging outdated stuff in, giving aikar free commits, smh, gets spammy too :D |
ExcessiveAmountsOfZombies
pushed a commit
to ExcessiveAmountsOfZombies/Paper
that referenced
this pull request
May 14, 2021
LeonTG
pushed a commit
to LeonTG/Paper
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the active item is not cleared, the item is still readied for use and will repeatedly trigger the PlayerItemConsumeEvent till their item is switched.
This patch clears the active item when the event is cancelled