Skip to content

Add AsyncPortalCreateEvent#5657

Closed
Machine-Maker wants to merge 1 commit into
PaperMC:masterfrom
Machine-Maker:feature/PortalCreateEvent-reasons
Closed

Add AsyncPortalCreateEvent#5657
Machine-Maker wants to merge 1 commit into
PaperMC:masterfrom
Machine-Maker:feature/PortalCreateEvent-reasons

Conversation

@Machine-Maker
Copy link
Copy Markdown
Member

@Machine-Maker Machine-Maker commented May 16, 2021 •
edited
Loading

Adds AsyncPortalCreateEvent with more reasons than the now-deprecated PortalCreateEvent. A new event is needed because it has to be fired in an asynchronous context which the old event didn't support.

- [ ] figure out what the correct buffer size for CraftLimitedRegion is

Closes #5547

@Machine-Maker Machine-Maker requested review from a team as code owners May 16, 2021 20:41
@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch 5 times, most recently from d421768 to 126a533 Compare May 20, 2021 19:13
@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from 126a533 to 32448be Compare May 24, 2021 19:06
@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from 32448be to 31318a3 Compare July 10, 2021 16:56
@Machine-Maker
Copy link
Copy Markdown
Member Author

Machine-Maker commented Jul 10, 2021

Rebased for 1.17.1

@stale
Copy link
Copy Markdown

stale Bot commented Sep 8, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from 31318a3 to 66d56b8 Compare September 8, 2021 20:06
@stale stale Bot removed the resolution: stale label Sep 8, 2021
NoahvdAa
NoahvdAa reviewed Sep 19, 2021
View reviewed changes
Comment thread patches/server/0806-More-PortalCreateEvent-reasons.patch Outdated
Comment thread patches/server/0806-More-PortalCreateEvent-reasons.patch Outdated
@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from 66d56b8 to 57178a1 Compare October 5, 2021 06:49
@stale
Copy link
Copy Markdown

stale Bot commented Dec 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from 57178a1 to d335673 Compare December 6, 2021 19:13
@stale stale Bot removed the resolution: stale label Dec 6, 2021
@Machine-Maker
Copy link
Copy Markdown
Member Author

Machine-Maker commented Dec 6, 2021

Rebased for 1.18

@stale
Copy link
Copy Markdown

stale Bot commented Feb 5, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from d335673 to c24e8ad Compare February 10, 2022 01:09
@stale stale Bot removed the resolution: stale label Feb 10, 2022
@stale
Copy link
Copy Markdown

stale Bot commented Apr 11, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from c24e8ad to 4508ee7 Compare April 16, 2022 21:11
@stale stale Bot removed the resolution: stale label Apr 16, 2022
@Machine-Maker
Copy link
Copy Markdown
Member Author

Machine-Maker commented Apr 16, 2022

Rebased for 1.18.2

@stale
Copy link
Copy Markdown

stale Bot commented Jun 18, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot removed the resolution: stale label Jun 25, 2022
@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from 4508ee7 to 9707cfe Compare June 25, 2022 20:53
@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from 9707cfe to b099e6d Compare December 18, 2022 20:45
@Machine-Maker
Copy link
Copy Markdown
Member Author

Machine-Maker commented Dec 18, 2022

Tested and rebased for 1.19.3

@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from b099e6d to 9c886e2 Compare December 18, 2022 23:07
Warriorrrr
Warriorrrr reviewed Aug 17, 2023
View reviewed changes
Comment thread patches/api/0423-More-PortalCreateEvent-reasons.patch Outdated
@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch 2 times, most recently from 0c6eb15 to faf240e Compare August 26, 2023 19:52
NoahvdAa
NoahvdAa reviewed Mar 29, 2024
View reviewed changes
Comment thread patches/api/0440-More-PortalCreateEvent-reasons.patch Outdated
Comment on lines +53 to +64
+ /**
+ * When an inactive end portal is generated on the main end
+ * island in the end dimension. This can happen in normal world generation or
+ * when a new dragon is spawned, replacing the active portal with a inactive one.
+ */
+ END_PORTAL,
+
+ /**
+ * When an active end portal is generated on the main end
+ * island in the end dimension.
+ */
+ ACTIVE_END_PORTAL,
Copy link
Copy Markdown
Member

@NoahvdAa NoahvdAa Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be clearer if we use EXIT_END_PORTAL (or END_EXIT_PORTAL) here to avoid confusion with activating the portal in the overworld.

@NoahvdAa NoahvdAa force-pushed the feature/PortalCreateEvent-reasons branch from faf240e to ff2a95c Compare May 6, 2024 17:24
@Machine-Maker Machine-Maker force-pushed the feature/PortalCreateEvent-reasons branch from ff2a95c to 5d2085c Compare July 18, 2024 01:27
@Machine-Maker Machine-Maker changed the title More PortalCreateEvent reasons Add AsyncPortalCreateEvent Jul 18, 2024
@Machine-Maker Machine-Maker marked this pull request as draft July 18, 2024 01:29
@Warriorrrr Warriorrrr moved this from Awaiting review to Waiting For Author in Paper PR Queue Mar 5, 2025
@kennytv kennytv added the pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch label Mar 23, 2025
@kennytv kennytv deleted the branch PaperMC:master March 23, 2025 19:15
@kennytv kennytv closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NoahvdAa NoahvdAa NoahvdAa left review comments

@Warriorrrr Warriorrrr Warriorrrr left review comments

Assignees

No one assigned

Labels

pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch pre-softspoon

Projects

Paper PR Queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

I can't cancel the creation of the end portal

5 participants

@Machine-Maker @NoahvdAa @Warriorrrr @MiniDigger @kennytv