Add flag for shadowJar task for no relocation#6207
Conversation
| + } | ||
| +} | ||
| + | ||
| +val noRelocation = providers.systemProperty("Paper.no-relocation").forUseAtConfigurationTime(); |
There was a problem hiding this comment.
I think I'd prefer this to just be a separate task. Would be simpler, 2 separate tasks that do different things, rather than 1 task which will do different things depending on the environment. The common parts of the task configuration could be pulled out via extension functions (examples):
https://github.com/PaperMC/paperweight/blob/main/buildSrc/src/main/kotlin/config-publish.gradle.kts#L14-L24
https://github.com/PaperMC/paperweight/blob/main/buildSrc/src/main/kotlin/config-publish.gradle.kts#L29
&
https://github.com/PaperMC/paperweight/blob/main/buildSrc/src/main/kotlin/config-publish.gradle.kts#L111-L138
https://github.com/PaperMC/paperweight/blob/main/buildSrc/src/main/kotlin/config-publish.gradle.kts#L67-L84
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed because it has not had activity in a long time. If the issue still applies to the most recent supported version, please open a new issue referencing this original issue. |
|
I was circling back to this, and now I'm not sure a separate task is useful now? Because there are 4 "jar" tasks, and you'd want a separate one for each. |
Machine-Maker
force-pushed
the
feature/no-relocation
branch
from
6cc9d07 to
5056f73
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Machine-Maker
force-pushed
the
feature/no-relocation
branch
from
5056f73 to
59c0bf0
Compare
|
Rebased and updated for grade 7.4 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Machine-Maker
force-pushed
the
feature/no-relocation
branch
from
59c0bf0 to
5b3d4fb
Compare
|
Superseded by this paperweight commit. |
4 participants
useful while running a debugger